Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Elasticsearch scaler #586

Merged
merged 7 commits into from
Nov 23, 2021

Conversation

orphaner
Copy link
Contributor

@orphaner orphaner commented Nov 19, 2021

Signed-off-by: Nicolas L [email protected]

Adds the documentation for the new born Elasticsearch scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Related to #2311
Relates to kedacore/keda#1756

@orphaner
Copy link
Contributor Author

Documentation: #586

@orphaner orphaner changed the title Adds documentation for Elasticsearch scaler Add documentation for Elasticsearch scaler Nov 19, 2021
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a few remarks/nits

content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Only 2 small nits related with the dots.
BTW, thanks a ton for your contribution ❤️

content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
content/docs/2.5/scalers/elasticsearch.md Outdated Show resolved Hide resolved
@zroubalik zroubalik merged commit e7bf5ab into kedacore:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants