-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Elasticsearch scaler #586
Merged
zroubalik
merged 7 commits into
kedacore:master
from
orphaner:elasticsearch-search-template
Nov 23, 2021
Merged
Add documentation for Elasticsearch scaler #586
zroubalik
merged 7 commits into
kedacore:master
from
orphaner:elasticsearch-search-template
Nov 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas L <[email protected]>
orphaner
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
November 19, 2021 08:47
Documentation: #586 |
orphaner
changed the title
Adds documentation for Elasticsearch scaler
Add documentation for Elasticsearch scaler
Nov 19, 2021
tomkerkhove
reviewed
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added a few remarks/nits
Signed-off-by: Nicolas L <[email protected]>
Signed-off-by: Nicolas L <[email protected]>
Signed-off-by: Nicolas L <[email protected]>
JorTurFer
requested changes
Nov 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Only 2 small nits related with the dots.
BTW, thanks a ton for your contribution ❤️
Signed-off-by: Nicolas L <[email protected]>
JorTurFer
approved these changes
Nov 22, 2021
zroubalik
requested changes
Nov 23, 2021
Signed-off-by: Nicolas L <[email protected]>
zroubalik
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nicolas L [email protected]
Adds the documentation for the new born Elasticsearch scaler
Checklist
Related to #2311
Relates to kedacore/keda#1756