Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for new GitHub App on GH Runner (#4651) #1159

Merged
merged 6 commits into from
Jun 21, 2023

Conversation

Eldarrin
Copy link
Contributor

Documentation to Support new GitHub App authentication on Scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #

kedacore/keda#4651

Relates #

kedacore/keda#4708

@Eldarrin Eldarrin requested a review from a team as a code owner June 19, 2023 09:28
@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for keda ready!

Name Link
🔨 Latest commit fa6d51e
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/6492f010c796d90008413a81
😎 Deploy Preview https://deploy-preview-1159--keda.netlify.app/docs/2.11/scalers/github-runner
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@piroinno
Copy link

Reviewed.

Eldarrin and others added 3 commits June 20, 2023 18:59
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Eldarrin <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Eldarrin <[email protected]>
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs, thanks! Just minor suggestion for the links

content/docs/2.11/scalers/github-runner.md Outdated Show resolved Hide resolved
content/docs/2.11/scalers/github-runner.md Outdated Show resolved Hide resolved
content/docs/2.11/scalers/github-runner.md Outdated Show resolved Hide resolved
Co-authored-by: Tom Kerkhove <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
@zroubalik zroubalik merged commit e2aa2be into kedacore:main Jun 21, 2023
@Eldarrin Eldarrin deleted the github-app branch June 21, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants