-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding support to the interceptor proxy for TLS on the wire #928
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this feature, could you add an e2e test for this? I think that covering this will prevent problems in the future xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an e2e test case for this scenario @zorocloud?
We should update docs as well for explaining how to configure this
Yeah no problem @JorTurFer. Planning to add them in once I get my other PR tied off. Just wanted to get the initial code up for feedback on the implementation :) |
sure! no rush, your other PR will be merged today (sorry, I've been on a trip this week) |
Hello @zorocloud |
Hey @JorTurFer, I will try and get it tied off this week, but I'm happy for it to go into a follow up release if it's not done in time. May as well stick with the current plan :) |
Well... we don't have any defined roadmap yet for the add-on, so given that you're working on this and I assume that you need the feature, we can cut a release v0.8.1 once it's the feature merged. Would it help? |
Works for me 👍 |
Signed-off-by: Joe Wogan <[email protected]>
Signed-off-by: Joe Wogan <[email protected]>
Couldn't bind 443 in the tests so just pushed a small update that should fix that. Think the tests should be good now and the PR ready for re-review whenever you have time :) |
Signed-off-by: Joe Wogan <[email protected]>
Nice, I'm going to check it now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AWESOME JOB! ❤️
Adding configurable TLS support to the interceptor proxy. Resolves #907
Checklist
README.md
docs/
directory