Skip to content

Commit

Permalink
chore(job-configuration): Use "TestCase" naming for abstract test cla…
Browse files Browse the repository at this point in the history
…sses

Since PHPUnit 10, the abstract classes with Test suffix are deprecated, see sebastianbergmann/phpunit#5132.
  • Loading branch information
janvanicek committed Nov 29, 2024
1 parent 1adc61b commit cdfc17f
Show file tree
Hide file tree
Showing 11 changed files with 13 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use RuntimeException;
use Symfony\Component\Filesystem\Filesystem;

abstract class BaseDataLoaderTest extends TestCase
abstract class BaseDataLoaderTestCase extends TestCase
{
private const DEFAULT_COMPONENT_STAGING_STORAGE_TYPE = 'local';
protected const COMPONENT_ID = 'docker-demo';
Expand Down
2 changes: 1 addition & 1 deletion tests/Mapping/InputDataLoader/ABSInputDataLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;

class ABSInputDataLoaderTest extends BaseInputDataLoaderTest
class ABSInputDataLoaderTest extends BaseInputDataLoaderTestCase
{
protected const DEFAULT_PROJECT = 'azure';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@
use Keboola\InputMapping\Staging\StrategyFactory;
use Keboola\JobQueue\JobConfiguration\Mapping\InputDataLoader;
use Keboola\JobQueue\JobConfiguration\Mapping\WorkspaceProviderFactoryFactory;
use Keboola\JobQueue\JobConfiguration\Tests\Mapping\BaseDataLoaderTest;
use Keboola\JobQueue\JobConfiguration\Tests\Mapping\BaseDataLoaderTestCase;
use Keboola\StagingProvider\InputProviderInitializer;
use Keboola\StorageApi\Components;
use Keboola\StorageApi\Workspaces;
use Keboola\StorageApiBranch\ClientWrapper;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

abstract class BaseInputDataLoaderTest extends BaseDataLoaderTest
abstract class BaseInputDataLoaderTestCase extends BaseDataLoaderTestCase
{
protected function getInputDataLoader(
?ClientWrapper $clientWrapper = null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Keboola\StorageApi\Workspaces;
use Symfony\Component\Filesystem\Filesystem;

class BigQueryInputDataLoaderTest extends BaseInputDataLoaderTest
class BigQueryInputDataLoaderTest extends BaseInputDataLoaderTestCase
{
protected const COMPONENT_ID = 'keboola.runner-workspace-bigquery-test';
protected const RESOURCE_SUFFIX = '-gcp-bq';
Expand Down
2 changes: 1 addition & 1 deletion tests/Mapping/InputDataLoader/GCSInputDataLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;

class GCSInputDataLoaderTest extends BaseInputDataLoaderTest
class GCSInputDataLoaderTest extends BaseInputDataLoaderTestCase
{
protected const RESOURCE_SUFFIX = '-gcp-gcs';
protected const DEFAULT_PROJECT = 'gcp';
Expand Down
2 changes: 1 addition & 1 deletion tests/Mapping/InputDataLoader/InputDataLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Keboola\StorageApi\Metadata;
use Symfony\Component\Filesystem\Filesystem;

class InputDataLoaderTest extends BaseInputDataLoaderTest
class InputDataLoaderTest extends BaseInputDataLoaderTestCase
{
protected const RESOURCE_SUFFIX = '-input';

Expand Down
2 changes: 1 addition & 1 deletion tests/Mapping/InputDataLoader/S3InputDataLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
use Keboola\JobQueue\JobConfiguration\JobDefinition\State\State;
use Symfony\Component\Filesystem\Filesystem;

class S3InputDataLoaderTest extends BaseInputDataLoaderTest
class S3InputDataLoaderTest extends BaseInputDataLoaderTestCase
{
protected const RESOURCE_SUFFIX = '-s3';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
use Keboola\StorageApiBranch\ClientWrapper;
use Keboola\StorageApiBranch\StorageApiToken;

class ABSPersistentOutputDataLoaderTest extends BaseOutputDataLoaderTest
class ABSPersistentOutputDataLoaderTest extends BaseOutputDataLoaderTestCase
{
protected const COMPONENT_ID = 'keboola.runner-config-test';
protected const DEFAULT_PROJECT = 'azure';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

use Keboola\JobQueue\JobConfiguration\Mapping\OutputDataLoader;
use Keboola\JobQueue\JobConfiguration\Mapping\WorkspaceProviderFactoryFactory;
use Keboola\JobQueue\JobConfiguration\Tests\Mapping\BaseDataLoaderTest;
use Keboola\JobQueue\JobConfiguration\Tests\Mapping\BaseDataLoaderTestCase;
use Keboola\OutputMapping\Staging\StrategyFactory as OutputStrategyFactory;
use Keboola\StagingProvider\OutputProviderInitializer;
use Keboola\StorageApi\Components;
Expand All @@ -15,7 +15,7 @@
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;

abstract class BaseOutputDataLoaderTest extends BaseDataLoaderTest
abstract class BaseOutputDataLoaderTestCase extends BaseDataLoaderTestCase
{
protected function getOutputDataLoader(
?ClientWrapper $clientWrapper = null,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
use Keboola\StorageApiBranch\Factory\ClientOptions;
use Symfony\Component\Filesystem\Filesystem;

class OutputDataLoaderMetadataTest extends BaseOutputDataLoaderTest
class OutputDataLoaderMetadataTest extends BaseOutputDataLoaderTestCase
{
private Metadata $metadata;

Expand Down
2 changes: 1 addition & 1 deletion tests/Mapping/OutputDataLoader/OutputDataLoaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
use ReflectionClass;
use Symfony\Component\Filesystem\Filesystem;

class OutputDataLoaderTest extends BaseOutputDataLoaderTest
class OutputDataLoaderTest extends BaseOutputDataLoaderTestCase
{
public function testExecutorDefaultBucket(): void
{
Expand Down

0 comments on commit cdfc17f

Please sign in to comment.