Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImageProcessors.GaussianBlur unavailable on watchOS makes building NukeUI for watchOS fail #710

Closed
FieryFlames opened this issue Jun 26, 2023 · 2 comments · Fixed by #711
Closed

ImageProcessors.GaussianBlur unavailable on watchOS makes building NukeUI for watchOS fail #710

FieryFlames opened this issue Jun 26, 2023 · 2 comments · Fixed by #711

Comments

@FieryFlames
Copy link
Contributor

Hi, the usage of ImageProcessors.GaussianBlur in the demo of LazyImage causes building NukeUI (& apps that want to use NukeUI) for watchOS fail. I would PR to fix, but unsure how best you'd want to fix this. I would just add a conditional checking if it's on watchOS and if it is don't include that processors modifier, but then the demo wouldn't blur when it's meant to.
@kean
Copy link
Owner

kean commented Jun 26, 2023

Hey, thanks for reporting it. I think it's OK to add a conditional check.

@FieryFlames
Copy link
Contributor Author

Ok, I will PR this shortly.

FieryFlames added a commit to FieryFlames/Nuke that referenced this issue Jun 26, 2023
@FieryFlames
Fix NukeUI errors for watchOS
0ae5feb 
Resolves kean#710
Material.ultraThick is available on watchOS 10 and up, but it seemed like too much work to conditionally apply it
@FieryFlames FieryFlames mentioned this issue Jun 26, 2023
Merged
@kean kean closed this as completed in #711 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix NukeUI errors for watchOS FieryFlames/Nuke
2 participants
@kean @FieryFlames