Skip to content
This repository has been archived by the owner on Feb 5, 2023. It is now read-only.

Linux support #12

Merged
merged 5 commits into from
Apr 27, 2020
Merged

Linux support #12

merged 5 commits into from
Apr 27, 2020

Conversation

heckj
Copy link
Contributor

@heckj heckj commented Apr 27, 2020

resolves #11

@heckj heckj marked this pull request as draft April 27, 2020 01:54
@heckj heckj marked this pull request as ready for review April 27, 2020 02:28
@heckj
Copy link
Contributor Author

heckj commented Apr 27, 2020

I couldn't vet the linux CI without some tweaking, so I saved that for last, will temp enable it on branches, but I vetted the code with:

swift test # checkin' mac local
brew install iainsmith/formulae/swift-docker # handy tool
swift docker test --args --enable-test-discovery # checkin' linux w/ swift 5.2

@kean
Copy link
Owner

kean commented Apr 27, 2020

Let me wrangle with CI later, I'm having some issues with GitHub integration.

Are you planning to do any additional changes or is it ready to be merged?

@heckj
Copy link
Contributor Author

heckj commented Apr 27, 2020

CI aside, that should be ready to roll - and I'm happy to rebase and squash this all if that would be easier for you.

@kean
Copy link
Owner

kean commented Apr 27, 2020

That's fine, let me do some testing later today before I merge it. Thanks for putting this together.

@kean kean merged commit 4db19cf into kean:master Apr 27, 2020
@kean
Copy link
Owner

kean commented Apr 27, 2020

@heckj, I updated the .travis.yml file. You can't use matrix in the kind of setup that I have, so I changed it a bit. I see that the tests on Linux have finished successfully https://travis-ci.org/github/kean/Future/builds/680205461 👍

@heckj heckj deleted the linux-support branch April 27, 2020 17:58
@heckj
Copy link
Contributor Author

heckj commented Apr 27, 2020

That's fantastic! I'm excited to see that running in CI for this project, and with that - I'm going to turn around and take a stab at using your awesome work within another project (ref SwiftDocOrg/DocTest#1) where it needs some synchronization support while running on Linux.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question - open to support swift on linux with this?
2 participants