Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dupe] feat: full edx-platform setup with tutor dev launch -m ... #29

Closed
wants to merge 2 commits into from

Conversation

kdmccormick
Copy link
Owner

@kdmccormick kdmccormick commented Mar 10, 2023

Closed in favor of overhangio#813

@kdmccormick kdmccormick force-pushed the kdmccormick/mounted-init branch 4 times, most recently from 10f8233 to 5876a05 Compare March 13, 2023 16:03
@kdmccormick kdmccormick force-pushed the kdmccormick/mounted-init branch 2 times, most recently from 7222ab1 to ebab66a Compare March 13, 2023 19:13
Before this commit, setting up an edx-platform development environment
took multiple steps:

   tutor dev launch
   tutor dev run --mount=/path/to/edx-platform lms bash
   >> pip install -e .
   >> npm clean-install
   >> openedx-assets build --env=dev

This commit moves the steps under ``run`` into an init task, which
is automatically run by ``launch``. Thus, setup is now one command:

   tutor dev launch --mount=edx-platform

These extra init steps are only applicable when bind-mounting
edx-platform (because bind-mounting the repository overrides
some important artifacts that exist on the image, which must be
re-generated). Thus, the new init tasks exists early if it detects
that it is *not* operating on a bind-mounted repository.

Finally, we try to simplify the Open edX development docs so that
it is clearer how bind-mounting fits into the development process.

Part of: openedx-unsupported/wg-developer-experience#146
Closes: openedx-unsupported/wg-developer-experience#152

This works around (but does not close) these related issues:
* openedx-unsupported/wg-developer-experience#150
* https://github.com/openedx/wg-developer-experience/issues/151
@kdmccormick kdmccormick force-pushed the kdmccormick/mounted-init branch from ebab66a to cac093b Compare March 13, 2023 19:14
@kdmccormick kdmccormick changed the title feat: full edx-platform setup with tutor dev launch -m ... [dupe] feat: full edx-platform setup with tutor dev launch -m ... Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants