Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command options for help and version #53

Merged
merged 2 commits into from
Apr 25, 2021
Merged

add command options for help and version #53

merged 2 commits into from
Apr 25, 2021

Conversation

ptt-homme
Copy link
Contributor

Fix #36

Hope this helps.

@kdabir
Copy link
Owner

kdabir commented Aug 31, 2020

Could you please make sure the tests pass with the commit? Happy to merge this once tests are updated.

@ptt-homme
Copy link
Contributor Author

Sure, I will!

Was my plan anyway to fix the CI :)

@ptt-homme ptt-homme force-pushed the add-help-version-options branch 3 times, most recently from 2d2f83e to 5e897a4 Compare August 31, 2020 12:41
@ptt-homme ptt-homme force-pushed the add-help-version-options branch from 5e897a4 to 1ec04eb Compare August 31, 2020 12:53
@ptt-homme
Copy link
Contributor Author

@kdabir

Tests are fixed now.
I added a new test to check if the usage message is printed when the flag -q is present and there is no .hasrc file or commands given.

I was wondering, would you let me rewrite the tests using bats-assert and bats-support? This will make writing tests less tedious (Ex. when comparing output).

@kdabir
Copy link
Owner

kdabir commented Aug 31, 2020

Sure, if makes the life easier for everyone, why not.

@ptt-homme
Copy link
Contributor Author

Great! I'll open a new PR with it.

This one can be merged :)

What are the rules to bump the version number ?

@ptt-homme ptt-homme mentioned this pull request Aug 31, 2020
Draft
@ptt-homme
Copy link
Contributor Author

@kdabir Any news about the project, is it still under development?

@kdabir
Copy link
Owner

kdabir commented Mar 24, 2021

Hey sorry for the silence on this PR since CI was failing I thought this is still work in progress.

@kdabir kdabir merged commit 868bc1a into kdabir:master Apr 25, 2021
@chenrui333 chenrui333 mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command options for help and version.
2 participants
@ptt-homme @kdabir