Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: use a unified java temurin distribution in CI #174

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

Now that we use two java distributions in CI, let's use temurin uniformly, remind me if i missed something,thanks.

- name: 'Set up JDK ${{ matrix.java }}'
uses: actions/setup-java@5ffc13f4174014e2d4d4572b3d74c3fa61aeb2c2
with:
java-version: ${{ matrix.java }}
distribution: 'zulu'
cache: 'maven'

- name: Set up JDK 8
uses: actions/setup-java@v4
with:
distribution: 'temurin'

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@liangyuanpeng
Copy link
Contributor Author

liangyuanpeng commented Jan 22, 2025

Opened a issue at actions/setup-java#734 for setup java failed

Run actions/setup-java@v4
  with:
    java-version: 8
    distribution: temurin
    cache: maven
    java-package: jdk
    check-latest: false
    server-id: github
    server-username: GITHUB_ACTOR
    server-password: GITHUB_TOKEN
    overwrite-settings: true
    job-status: success
    token: ***
  env:
    ROOT_POM: pom.xml
Installed distributions
  Trying to resolve the latest version from remote
  Error: Could not find satisfied version for SemVer '8'. 
  Available versions: [2](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:2)3.0.1+11, 2[3](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:3).0.0+37, 22.0.2+9, 22.0.1+8, 22.0.0+36, 21.0.5+11.0.LTS, 21.0.[4](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:4)+7.0.LTS, 21.0.3+9.0.LTS, 21.0.2+13.0.LTS, 21.0.1+12.0.LTS, 21.0.0+3[5](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:5).0.LTS, 20.0.2+9, 20.0.1+9, 20.0.0+3[6](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:6), 19.0.2+7, 19.0.1+10, 19.0.0+36, 18.0.2+101, 18.0.2+9, 18.0.1+10, 18.0.0+36, 1[7](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:7).0.13+11, 17.0.12+7, 17.0.11+9, 17.0.10+7, 17.0.9+9, 17.0.[8](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:8)+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 17.0.0+35, 11.0.25+[9](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:9), 11.0.24+8, 11.0.23+9, 11.0.22+7.1, 11.0.22+7, 11.0.21+9, 11.0.20+[10](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:10)1, 11.0.20+8, 11.0.19+7, 11.0.18+10, [11](https://github.com/kcl-lang/lib/actions/runs/12905952208/job/35986237841?pr=174#step:3:11).0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10

@liangyuanpeng
Copy link
Contributor Author

https://adoptium.slack.com/archives/C09NLQQAV/p1737598104366369

temurin no plans to support macos arm64 for java8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant