Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kcl wasm lib both for node.js and browser #137

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Aug 26, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y
  • feat: kcl wasm lib both for node.js and browser

@Peefy Peefy force-pushed the feat-kcl-wasm-in-browser branch from b987f9f to dfd1396 Compare August 26, 2024 12:30
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy force-pushed the feat-kcl-wasm-in-browser branch from dfd1396 to f1c3fab Compare August 26, 2024 12:37
@Peefy Peefy force-pushed the feat-kcl-wasm-in-browser branch from f1c3fab to 8bb96f2 Compare August 26, 2024 12:38
Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 226986d into kcl-lang:main Aug 27, 2024
4 checks passed
@Peefy Peefy deleted the feat-kcl-wasm-in-browser branch August 27, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants