Skip to content

Commit

Permalink
Converge request user roles
Browse files Browse the repository at this point in the history
We introduced feature miq_request_superadmin in f6c02e8 / ManageIQ#17444 
The feature miq_request_approval already existed.
Merging the 2 together.

This fixes an inconsistency between API and UI
The issue existed before this feature was introduced
so this works with 17444 to fix the BZ

ManageIQ#17444
https://bugzilla.redhat.com/show_bug.cgi?id=1608554
  • Loading branch information
kbrock committed Aug 14, 2018
1 parent 3a5bba6 commit 98ee56e
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/models/miq_product_feature.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
class MiqProductFeature < ApplicationRecord
SUPER_ADMIN_FEATURE = "everything".freeze
REPORT_ADMIN_FEATURE = "miq_report_superadmin".freeze
REQUEST_ADMIN_FEATURE = "miq_request_superadmin".freeze
REQUEST_ADMIN_FEATURE = "miq_request_approval".freeze
ADMIN_FEATURE = REPORT_ADMIN_FEATURE
acts_as_tree

Expand Down
4 changes: 0 additions & 4 deletions db/fixtures/miq_product_features.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,6 @@
:description: Edit a Request
:feature_type: admin
:identifier: miq_request_edit
- :name: Request Admin
:description: Edit other user's requests
:feature_type: admin
:identifier: miq_request_superadmin

# Catalog Items
- :name: Catalogs Explorer
Expand Down
2 changes: 1 addition & 1 deletion db/fixtures/miq_user_roles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
- miq_report
- miq_report_superadmin
- miq_request
- miq_request_superadmin
- miq_request_approval
- miq_template
- orchestration_stack
- physical_server
Expand Down

0 comments on commit 98ee56e

Please sign in to comment.