Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

Use correct package as root of dependency graph #38

Merged
merged 7 commits into from
Nov 27, 2017
Merged

Use correct package as root of dependency graph #38

merged 7 commits into from
Nov 27, 2017

Conversation

remram44
Copy link
Contributor

Fixes #33

@remram44
Copy link
Contributor Author

Some other fixes are included, since the project didn't build with --features debug (4c5e60d), and there were some issues with the debug output (e955ce2, 0f35e13).

@remram44
Copy link
Contributor Author

Updated my fix for rust-lang/cargo#4571. Cargo.toml files created from current cargo make cargo-graph fail with error: No root table found for toml file.

@kbknapp
Copy link
Owner

kbknapp commented Nov 20, 2017

sorry for missing this! My work schedule has been nuts the last few months and I haven't had time to keep up with these subcommands. Could you rebase on the latest master and this shouod be good for a merge.

@remram44
Copy link
Contributor Author

Sure thing! Rebased without conflict. Note that a cargo update might be required to build on current nightly, rustc-serialize 0.3.18 fails to build.

@kbknapp
Copy link
Owner

kbknapp commented Nov 20, 2017

thanks! If the latest rustc-serialize isn't breaking and builds on stable-2 I don't mind just rolling that up into this PR

@kbknapp
Copy link
Owner

kbknapp commented Nov 20, 2017

I'm on mobile right now though and can't test if that's the case

@remram44
Copy link
Contributor Author

No problem, committed a cargo update. Builds on stable (1.21) and nightly. Thanks!

@kbknapp
Copy link
Owner

kbknapp commented Nov 27, 2017

Thanks!

@kbknapp kbknapp merged commit d895af1 into kbknapp:master Nov 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants