Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General standard deck test coverage with couple bug fixes. #29

Merged
merged 13 commits into from
Jul 19, 2022

Conversation

ismemang
Copy link
Contributor

Standard deck test coverage and to see that it was complete enough for me to use in another project. I ended up fixing what I believe to be a couple small bugs in _deck as well.

  • Optional test results report.
  • Optional test coverage report.
  • Test coverage mainly of StandardDeck.
npm run test:unit
open report/test/unit/results/index.html
npm run test:unit:cover
open report/test/unit/coverage/index.html

# Help prove the bug fixes.
npm run test:unit -- --grep 'when the card is added to the deck'
npm run test:unit -- --grep 'when the two decks are merged'

@ismemang
Copy link
Contributor Author

Would it be preferred that I break the bug (potential) fixes out into their own PR?

@kbjr kbjr merged commit 014b711 into kbjr:master Jul 19, 2022
@kbjr
Copy link
Owner

kbjr commented Jul 19, 2022

No, this works fine for me.
Bug fix published in 2.0.2

@ismemang ismemang deleted the test-general-coverage branch July 20, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants