Separate concerns and update certs #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves render time by limiting the number of times cytoscape has to use its layout functionality. This can be further improved with changes to the nodeRepulsion function. It also decouples computing the table data from displaying the table data. There is more work to be done in this area. These changes solve a bug where a tippy would be frozen if it was shown during a state change and generally improve the user experience.
The base image contains stale root certificates which caused builds to fail. This happened when requesting the node setup script which uses a Let's Encrypt signed certificate. The site's certificate is up to date, but the old root certificate in the container, which has long since been replaced, finally expired. This was compounded initially because the script download failed silently, but this updates it to fail at the first sign of trouble.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a few steps to separate concerns of computing the gene data to display and computing the DOM changes necessary to reflect those change in the data table. It also updates certificates on build to avoid using expired certificates shipped with the underlying OS, that is,
debian stretch.