Flattening sets out of data_exporter output #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #113 +/- ##
===========================================
+ Coverage 72.47% 72.54% +0.07%
===========================================
Files 24 24
Lines 1544 1548 +4
===========================================
+ Hits 1119 1123 +4
Misses 425 425 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ialarmedalien
force-pushed
the
flatten_data
branch
from
27dbd48 to
ab00677
Compare
briehl
requested changes
Jul 9, 2024
| obj_type = obj[2].split("-")[0] | ||
| if obj_type in IGNORED_TYPES: | ||
| return | ||
| obj_upa = generate_upa(item[OBJ_INFO]) |
There was a problem hiding this comment.
You already have obj defined as that above, might as well use it!
| def _index_obj( | ||
| item: dict[str, Any], type_info: dict[str, Any], indexed_data: dict[str, Any] | ||
| ) -> None: | ||
| """Index by object ID and save the type information.""" |
There was a problem hiding this comment.
May want to note for posterity that this has the side effects of updating the input dicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR purpose/changes
Jira Ticket / Issue
Related Jira ticket: https://kbase-jira.atlassian.net/browse/DATAUP-X
DATAUP-69 Adds a PR template)Testing Instructions
Dev Checklist:
StaticNarrativeImpl.py,StaticNarrativeServer.py, andcompile_report.jsonto this PR.Updating Version and Release Notes (if applicable)