Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CDM NavItem and CDM Redirect #235

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Add CDM NavItem and CDM Redirect #235

merged 4 commits into from
Feb 11, 2025

Conversation

dauglyon
Copy link
Collaborator

@dauglyon dauglyon commented Feb 4, 2025

Also adds role-based hide/show to NavItems (only CDM admins will see the button right now), and role-based pseudo-404 routing to the Authed component (to hide this route from normal users in prod)

@dauglyon dauglyon requested a review from dakotablair February 4, 2025 18:58
@dauglyon dauglyon force-pushed the cdm-fast-login-stub branch from c655e25 to 6d230de Compare February 4, 2025 19:01
@dauglyon dauglyon changed the title Stub out CDM navigation and add role-controlled NavItems and Routes Add CDM NavItem which POSTs a login request to ${CDM}/hub/login Feb 5, 2025
@dauglyon dauglyon changed the title Add CDM NavItem which POSTs a login request to ${CDM}/hub/login Add CDM NavItem and CDM Redirect Feb 6, 2025
Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<insert rubber-stamp noise here>

@dauglyon dauglyon merged commit 70e1a1f into main Feb 11, 2025
4 checks passed
@dauglyon dauglyon deleted the cdm-fast-login-stub branch February 11, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants