Fix Backup cookie #227
Merged
Fix Backup cookie #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndition, add backup cookie tests
dauglyon
commented
Sep 24, 2024
| @@ -60,6 +61,7 @@ const setEnvironment = ( | |||
| REACT_APP_KBASE_DOMAIN: domain, | |||
| REACT_APP_KBASE_LEGACY_DOMAIN: legacy, | |||
| REACT_APP_KBASE_BACKUP_COOKIE_NAME: backupCookie?.name || '', | |||
| REACT_APP_KBASE_BACKUP_COOKIE_DOMAIN: backupCookie?.domain || '', | |||
There was a problem hiding this comment.
Added the ability to test cookies independently, added new backup cookie tests
There was a problem hiding this comment.
This should catch a mismatched configuration in the future.
briehl
approved these changes
Sep 25, 2024
dakotablair
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the backup cookie issue. It fixes the cookie configuration, adds tests specific to the backup cookie, and adds a missing condition that obfuscated the configuration error and accidentally worked only on login/logout or when a backup cookie was already present.