Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some auth cleanup for clarity #207

Merged
merged 2 commits into from
May 16, 2024
Merged

Some auth cleanup for clarity #207

merged 2 commits into from
May 16, 2024

Conversation

dauglyon
Copy link
Collaborator

@dauglyon dauglyon commented May 2, 2024

No description provided.

@dauglyon dauglyon marked this pull request as ready for review May 15, 2024 18:49
@dauglyon dauglyon requested a review from dakotablair May 15, 2024 18:49
dakotablair
dakotablair approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@dakotablair dakotablair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I like how you reorganized these tests and improved their clarity.

@dauglyon dauglyon merged commit ae10b40 into main May 16, 2024
4 checks passed
@dauglyon dauglyon deleted the auth-cleanup branch May 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakotablair dakotablair dakotablair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dauglyon @dakotablair