RE2022-236 Heatmap context tabs #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dauglyon
commented
Apr 15, 2024
•
dauglyon
commented
- Include filter context tabs (All/Matched/Selected) in Microtrait and Biolog data products
- Heatmap should render filtered data based on the selected tab
dauglyon
force-pushed
the
heatmapContextTabs
branch
2 times, most recently
from
10cba13 to
0223241
Compare
dauglyon
force-pushed
the
heatmapContextTabs
branch
from
0223241 to
6a369dd
Compare
dauglyon
commented
Apr 26, 2024
| @@ -104,7 +104,7 @@ export const useProcessStatePolling = < | |||
| result: R, | |||
| processStateKeys: StateKey[], | |||
| options?: { baseInterval?: number; rate?: number; skipPoll?: boolean } | |||
| ) => { | |||
| ): Partial<{ [processStateKey in StateKey]: ProcessState }> => { | |||
There was a problem hiding this comment.
Adding a return from useProcessStatePolling hook for easier/clearer access to polling states
dauglyon
commented
Apr 26, 2024
| biologQuery.data.data[ | ||
| biologQuery.data.data.length - 1 | ||
| ].kbase_display_name; | ||
| const name = |
There was a problem hiding this comment.
fixes case where there is no data (empty table from service) to pull the cached name (paging id) from
dakotablair
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.