Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URO 95: Configure Google Analytics 4 #128

Merged
merged 4 commits into from
Nov 29, 2023
Merged

URO 95: Configure Google Analytics 4 #128

merged 4 commits into from
Nov 29, 2023

Conversation

dakotablair
Copy link
Collaborator

@dakotablair dakotablair commented Nov 28, 2023 •
edited
Loading

  • Add G4A and GTag tracking, implement and use appropriate hooks for both, integrating with react-router
  • MUST support legacy routes and new routes
  • Coordinate with credit-engine team about user-id tracking.
  • Request review from @briehl

@dakotablair dakotablair requested a review from briehl November 28, 2023 20:09
briehl
briehl approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@briehl briehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the rest of the PR, but the last 4 commits around GA4 look good to me.

Thanks @dakotablair !

@dakotablair dakotablair marked this pull request as ready for review November 29, 2023 14:19
@dakotablair dakotablair merged commit 7f15cc3 into main Nov 29, 2023
3 checks passed
@dakotablair dakotablair deleted the ga4 branch November 29, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briehl briehl briehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakotablair @briehl