Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URO-164 URO-169 URO-171 Add delete functionality, messaging and basic error handling. #104

Merged
merged 10 commits into from
Sep 8, 2023
Merged

URO-164 URO-169 URO-171 Add delete functionality, messaging and basic error handling. #104

merged 10 commits into from
Sep 8, 2023

Conversation

dakotablair
Copy link
Collaborator

@dakotablair dakotablair commented Aug 16, 2023 •
edited
Loading

  • URO-164 Narratives can be deleted using the Narrative Control Menu.
    • Update modals to use createPortal.
    • If the action is confirmed to succeed, show a message to the user using a toast notification.
    • If the action fails, show a message to the user using a toast notification. Have distinct messages for when:
      • The app is unable to confirm action success.
  • URO-169 Add toast notifications for user messaging.
    • Any app messages may be relayed by a toast notification.
  • URO-171 Filter left nav bar by customroles.
  • Use better Modals.

@dakotablair dakotablair changed the title URO-164 URO-169 URO-164 URO-169 Add delete functionality, messaging and basic error handling. Aug 23, 2023
@dakotablair
Make tests more verbose.
605a6c1
@dakotablair
Use improved Modals in NarrativeControl.
2ff540f
@dakotablair
Add getMe call to get user data from auth.
c70a2ad 
This commit introduces a getMe call to inspect the customroles for a user.
This is used in the <LeftNavBar /> component to show or hide development views.
This commit also factors auth related hooks into features/auth/hooks.
@dakotablair
Replace emptyFunction with noOp.
130f61f
@dakotablair
Add delete workspace call and allow JSON-RPC 2.0.
1c54404
@dakotablair
Add state to track loading and sync status.
3db18bd 
Remove vestigal ModalContext and use toasts, adding toast dependencies.
@dakotablair
Silence console.info during testing.
51ac1ee
@dakotablair
Add tests for <Delete /> component and others,
6014c9f 
including the <RefreshButton /> component and the normalizeVersion function.
@dakotablair dakotablair marked this pull request as ready for review September 6, 2023 16:28
@dakotablair dakotablair requested a review from dauglyon September 6, 2023 16:28
@dakotablair dakotablair changed the title URO-164 URO-169 Add delete functionality, messaging and basic error handling. URO-164 URO-169 URO-171 Add delete functionality, messaging and basic error handling. Sep 7, 2023
@dakotablair dakotablair merged commit 5f69af7 into main Sep 8, 2023
@dakotablair dakotablair deleted the navigator branch September 8, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dauglyon dauglyon dauglyon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakotablair @dauglyon