Skip to content

Commit

Permalink
Add HARDCODED callout comments
Browse files Browse the repository at this point in the history
  • Loading branch information
dauglyon committed Apr 30, 2024
1 parent b016563 commit d3c155e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions src/features/collections/CollectionDetail.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ export const CollectionDetail = () => {
const handleSearchDebounced = useDebounce<
React.ChangeEventHandler<HTMLInputElement>
>((e) => {
// HARDCODED Here we are using the `classification` filter as our default search filter
const filter = filters?.['classification'];
if (
!collection ||
Expand Down
6 changes: 5 additions & 1 deletion src/features/collections/data_products/GenomeAttribs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ export const GenomeAttribs: FC<{
</Link>
);
}
: field.name === 'classification'
: // HARDCODED Special rendering for the `classification` column
field.name === 'classification'
? (cell) => {
return (
<Tooltip
Expand All @@ -240,6 +241,7 @@ export const GenomeAttribs: FC<{
}
: undefined,
})),
// HARDCODED the field order parameter and the hidden fields parameter hardcode overrides for which columns will appear and in what order
order: ['kbase_display_name', 'kbase_id', 'genome_size'],
exclude: ['__match__', '__sel__'],
});
Expand Down Expand Up @@ -287,6 +289,7 @@ export const GenomeAttribs: FC<{
width: '100%',
}}
>
{/* HARDCODED Plots are currently hardcoded for certain columns in the existing collections schema */}
<AttribScatter
collection_id={collection_id}
xColumn={
Expand All @@ -313,6 +316,7 @@ export const GenomeAttribs: FC<{
width: '100%',
}}
>
{/* HARDCODED Plots are currently hardcoded for certain columns in the existing collections schema */}
<AttribHistogram
collection_id={collection_id}
column={
Expand Down
1 change: 1 addition & 0 deletions src/features/collections/data_products/SampleAttribs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,7 @@ export const SampleAttribs: FC<{
}
: undefined,
})),
// HARDCODED the field order parameter and the hidden fields parameter hardcode overrides for which columns will appear and in what order
order: [
'kbase_display_name',
'kbase_id',
Expand Down

0 comments on commit d3c155e

Please sign in to comment.