Merge pull request #215 from kbase/URO-209

URO-209: add additional content and tests to orcidlink

package.json

@@ -80,6 +80,7 @@
     "@typescript-eslint/eslint-plugin": "^5.55.0",
     "@typescript-eslint/parser": "^5.46.1",
     "babel-plugin-named-exports-order": "^0.0.2",
+    "core-js": "3.37.1",
     "eslint-plugin-prettier": "^3.4.0",
     "husky": "^7.0.1",
     "prettier": "^2.3.2",
@@ -96,6 +97,9 @@
     "stylelint-config-standard": "^22.0.0",
     "webpack": "^5.75.0"
   },
+  "overrides": {
+    "@testing-library/dom": "^9.0.1"
+  },
   "engines": {
     "node": ">=20.11.1"
   },

src/app/Routes.tsx

@@ -26,6 +26,7 @@ import {
   usePageTracking,
 } from '../common/hooks';
 import ORCIDLinkFeature from '../features/orcidlink';
+import ORCIDLinkCreateLink from '../features/orcidlink/CreateLink';
 
 export const LOGIN_ROUTE = '/legacy/login';
 export const ROOT_REDIRECT_ROUTE = '/narratives';
@@ -83,6 +84,9 @@ const Routes: FC = () => {
       <Route path="/orcidlink">
         <Route index element={<Authed element={<ORCIDLinkFeature />} />} />
       </Route>
+      <Route path="/orcidlink/link">
+        <Route index element={<Authed element={<ORCIDLinkCreateLink />} />} />
+      </Route>
 
       {/* IFrame Fallback Routes */}
       <Route path="/fallback">

src/features/orcidlink/CreateLink/index.test.tsx

@@ -0,0 +1,135 @@
+import { render, screen, waitFor } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { Provider } from 'react-redux';
+import { MemoryRouter, Route, Routes } from 'react-router-dom';
+import { createTestStore } from '../../../app/store';
+import { INITIAL_STORE_STATE } from '../test/data';
+import CreateLinkIndex from './index';
+
+describe('The CreateLink component', () => {
+  const user = userEvent.setup();
+  let debugLogSpy: jest.SpyInstance;
+  beforeEach(() => {
+    jest.resetAllMocks();
+  });
+  beforeEach(() => {
+    debugLogSpy = jest.spyOn(console, 'debug');
+  });
+
+  async function expectAccordion(
+    container: HTMLElement,
+    titleText: string,
+    contentText: string
+  ) {
+    expect(container).toHaveTextContent(titleText);
+
+    const faq1Content = await screen.findByText(new RegExp(contentText), {
+      exact: false,
+    });
+
+    expect(faq1Content).not.toBeVisible();
+
+    const faq1Title = await screen.findByText(new RegExp(titleText), {
+      exact: false,
+    });
+    await user.click(faq1Title);
+
+    await waitFor(() => {
+      expect(faq1Content).toBeVisible();
+    });
+  }
+
+  it('renders placeholder content', () => {
+    const { container } = render(
+      <Provider store={createTestStore(INITIAL_STORE_STATE)}>
+        <MemoryRouter initialEntries={['/foo']}>
+          <CreateLinkIndex />
+        </MemoryRouter>
+      </Provider>
+    );
+
+    expect(container).toHaveTextContent('Create Your KBase ORCID® Link');
+    expect(container).toHaveTextContent('FAQs');
+    expect(document.title).toBe('KBase: ORCID Link - Create Link');
+  });
+
+  it('cancel button returns to the ORCID Link home page', async () => {
+    const user = userEvent.setup();
+    let fakeHomeCalled = false;
+    function FakeHome() {
+      fakeHomeCalled = true;
+      return <div>FAKE HOME</div>;
+    }
+    const { container } = render(
+      <Provider store={createTestStore(INITIAL_STORE_STATE)}>
+        <MemoryRouter initialEntries={['/orcidlink/link']}>
+          <Routes>
+            <Route path={'orcidlink/link'} element={<CreateLinkIndex />} />
+            <Route path={'orcidlink'} element={<FakeHome />} />
+          </Routes>
+        </MemoryRouter>
+      </Provider>
+    );
+
+    expect(container).toHaveTextContent('Create Your KBase ORCID® Link');
+    expect(container).toHaveTextContent('FAQs');
+    expect(document.title).toBe('KBase: ORCID Link - Create Link');
+
+    const cancelButton = await screen.findByText('Cancel');
+    await user.click(cancelButton);
+
+    await waitFor(() => {
+      expect(fakeHomeCalled).toBe(true);
+    });
+  });
+
+  it('cancel button returns to the ORCID Link home page', async () => {
+    const user = userEvent.setup();
+    const { container } = render(
+      <Provider store={createTestStore(INITIAL_STORE_STATE)}>
+        <MemoryRouter initialEntries={['/orcidlink/link']}>
+          <Routes>
+            <Route path={'orcidlink/link'} element={<CreateLinkIndex />} />
+          </Routes>
+        </MemoryRouter>
+      </Provider>
+    );
+
+    expect(container).toHaveTextContent('Create Your KBase ORCID® Link');
+    expect(container).toHaveTextContent('FAQs');
+    expect(document.title).toBe('KBase: ORCID Link - Create Link');
+
+    const continueButton = await screen.findByText('Continue to ORCID®');
+    await user.click(continueButton);
+
+    await waitFor(() => {
+      expect(debugLogSpy).toHaveBeenCalledWith(
+        'WILL START THE LINKING PROCESS'
+      );
+    });
+  });
+
+  it('faq accordions are present and work', async () => {
+    const { container } = render(
+      <Provider store={createTestStore(INITIAL_STORE_STATE)}>
+        <MemoryRouter initialEntries={['/orcidlink/link']}>
+          <Routes>
+            <Route path={'orcidlink/link'} element={<CreateLinkIndex />} />
+          </Routes>
+        </MemoryRouter>
+      </Provider>
+    );
+
+    expectAccordion(
+      container,
+      "What if I don't have an ORCID® Account",
+      "But what if you don't have an ORCID® account?"
+    );
+
+    expectAccordion(
+      container,
+      'But I already log in with ORCID®',
+      'Your ORCID® sign-in link is only used to obtain your ORCID® iD during sign-in'
+    );
+  });
+});