test handle service 2 container endpoints #122
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
Xiangs18
requested review from
MrCreosote
and removed request for
github-actions[bot]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #122 +/- ##
========================================
Coverage 84.13% 84.13%
========================================
Files 5 5
Lines 416 416
========================================
Hits 350 350
Misses 66 66 ☔ View full report in Codecov by Sentry. |
| FILE_NAME = "mylittlefile" | ||
|
|
||
| HS_URL = "http://localhost:8080" | ||
| BLOB_URL = "https://ci.kbase.us/services/shock-api" |
There was a problem hiding this comment.
If you want to make this truly standalone you could add auth and the blobstore to the docker compose, similar to how the workspace does it with auth. Then you don't need a token. Maybe not enough ROI though.
There was a problem hiding this comment.
I think this is good for now. If you think is necessary, I can address this after I get myself unblocked from jgi-kbase/IDMappingService#140
There was a problem hiding this comment.
Lintly has detected code quality issues in this pull request.
| max_attempts = len(WAIT_TIMES) + 1 | ||
| while attempt <= max_attempts: | ||
| print(f"Attempt {attempt} of {max_attempts}") | ||
| hs = AbstractHandle(HS_URL) |
There was a problem hiding this comment.
You could move this out of the loop, no need to reconstruct it every time
Xiangs18
dismissed
github-actions[bot]’s stale review
Lintly doesn't seem to dismiss old reviews when it passes
No description provided.