Change data type of Max-Forwards header from u32 to u8 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://datatracker.ietf.org/doc/html/rfc3261#section-20.22, only values 0-255 are allowed
|
The checks are failing because of some doc linting problem. I am not sure if the suggestion from clippy is correct. If you have time, can you check that @kbalt ? |
|
Any updates on the review process? |
|
Thanks! What is your plan for publishing a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in https://datatracker.ietf.org/doc/html/rfc3261#section-20.22 it says that only the values 0-255 are allowed, u32 would allow more than that.
So I suggest to change the data type to u8.