Should warn unknown if named format is not closed #435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434
I believe that: if
{named_format
is NOT closed (missing}
) , the belowwhile
loops infintely and bloat the string variablesub
, thus causes memory allocation error.vue-i18n/src/format.js
Lines 48 to 51 in 94583e5
Personally, I prefer
error
to be thrown, so that one can notice the invalid named format while development.But I follow the current design: logging
warn
rather than throwingerror
.