🐛 bug(format): Should warn as unknown if named format is not closed. (#…

…435) by @exoego
kazupon · Oct 12, 2018 · d1f6ed0 · d1f6ed0
1 parent 94583e5
commit d1f6ed0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/src/format.js b/src/format.js
@@ -45,14 +45,15 @@ export function parse (format: string): Array<Token> {
       text = ''
       let sub: string = ''
       char = format[position++]
-      while (char !== '}') {
+      while (char !== undefined && char !== '}') {
         sub += char
         char = format[position++]
       }
+      const isClosed = char === '}'
 
       const type = RE_TOKEN_LIST_VALUE.test(sub)
         ? 'list'
-        : RE_TOKEN_NAMED_VALUE.test(sub)
+        : isClosed && RE_TOKEN_NAMED_VALUE.test(sub)
           ? 'named'
           : 'unknown'
       tokens.push({ value: sub, type })

diff --git a/test/unit/format.test.js b/test/unit/format.test.js
@@ -85,6 +85,13 @@ describe('compile', () => {
       assert.equal(compiled[2], ', age: ')
       assert.equal(compiled[3], '0x20')
     })
+
+    it('should be compiled as unknown if not closed', () => {
+      const tokens = parse('name: {name')
+      const compiled = compile(tokens, { name: 'kazupon' })
+      assert(compiled.length === 1)
+      assert.equal(compiled[0], 'name: ')
+    })
   })
 
   describe('unknown token', () => {
@@ -103,6 +110,7 @@ describe('compile', () => {
     })
   })
 
+
   describe('values unknown mode', () => {
     it('should be compiled with empty', () => {
       const compiled = compile([], 1)