Joss paper typo edits #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kazewong,
Opening PR for (first pass) typo edits as part of JOSS review openjournals/joss-reviews#5021
I'll leave some comments about the paper in a separate issue / on the JOSS review checklist. But one key thing to note, is that more citations are needed. For example, JAX should be cited, and so should Flax. Additionally, some claims are not cited e.g. in the opening paragraph "the estimation of model parameters becomes challenging as the dimension of the parameter space grows" or "MCMC methods can struggle to faithfully represent the parameter space when only relying on local updates".
Cheers,
Dan