Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced the usage of deepcopy #161

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Replaced the usage of deepcopy #161

merged 1 commit into from
Sep 26, 2018

Conversation

twheys
Copy link
Contributor

@twheys twheys commented Sep 26, 2018 •
edited
Loading

Replaced the usage of deepcopy in the @builder decorator with copy and overrode copy in QueryBuilder

Fixes #160

@twheys twheys self-assigned this Sep 26, 2018
@twheys twheys mentioned this pull request Sep 26, 2018
Closed
@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 98.015% when pulling e5f7b2d on remove_deepcopy into bb3a9a1 on master.

gl3nn
gl3nn reviewed Sep 26, 2018
View reviewed changes
pypika/queries.py Outdated Show resolved Hide resolved
mikeengland
mikeengland reviewed Sep 26, 2018
View reviewed changes
pypika/queries.py Outdated Show resolved Hide resolved
@twheys twheys merged commit 1ee37fb into master Sep 26, 2018
@twheys twheys deleted the remove_deepcopy branch September 26, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeengland mikeengland mikeengland approved these changes

@gl3nn gl3nn gl3nn left review comments

Assignees

@twheys twheys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twheys @coveralls @gl3nn @mikeengland