Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links export options parsing #596

Merged
merged 4 commits into from
Mar 18, 2022
Merged

Fix broken links export options parsing #596

merged 4 commits into from
Mar 18, 2022

Conversation

kaushalmodi
Copy link
Owner

This fix was possible after the AST looping was moved outside the
with-temp-buffer construct: #595

Fixes #587

@kaushalmodi
fix: Detecting broken-links:t in :EXPORT_OPTIONS: now works
037cff5 
This fix was possible after the AST looping was moved outside the
`with-temp-buffer` construct:
#595

Fixes #587.
@kaushalmodi
Cleanup: Remove some commented out debug code
0a28ae9
@kaushalmodi kaushalmodi mentioned this pull request Mar 18, 2022
Closed
3 tasks
@kaushalmodi
Copy link
Owner Author

Oh well, this fix works locally on Org built from main branch, but it's failing on the latest stable version 9.5.2 😐

@kaushalmodi
fix: Set the starting position to search for EXPORT_OPTIONS
c8c9cb8 
When the target file is not open, the start position defaults to 1 and
so the EXPORT_OPTIONS in the heading where we intend to search is
never found.
@kaushalmodi kaushalmodi merged commit e1a3e07 into main Mar 18, 2022
@kaushalmodi kaushalmodi deleted the fix-broken-links-export-options-parsing branch March 18, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow exporting with broken links if broken-links: t
1 participant
@kaushalmodi