Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese (Traditional) Translation of README #2043

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Jan 20, 2023

TODOs

  • Add flag of Taiwan to README.md

Translated Part

Full

  • README.md

Partial (Outline, Introduction, etc.)

  • _examples/README.md (Outline completed; Description partially)

Breaking Changes

  • *_ZH.md has been moved to *_ZH_HANS.md to not be confused with *_ZH_HANT.md. The links pointed to this should be updated.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@pan93412 pan93412 marked this pull request as ready for review January 20, 2023 13:11
@pan93412 pan93412 requested a review from kataras as a code owner January 20, 2023 13:11
@kataras
Copy link
Owner

kataras commented Jan 24, 2023

Hello @pan93412, great work I have to find and upload the flag (if differs from the existing)! May I ask if we can remove the History document part from this PR, because it's not yet fully translated?

@pan93412
Copy link
Contributor Author

Hello @pan93412, great work I have to find and upload the flag (if differs from the existing)! May I ask if we can remove the History document part from this PR, because it's not yet fully translated?

Sure! I'll remove it.

@kataras kataras added good first issue A user wrote a good first issue with clear instructions 📒 type:documentation labels Jan 27, 2023
@kataras kataras merged commit 605b6e4 into kataras:master Jan 27, 2023
Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pan93412, approved!

@pan93412 pan93412 deleted the zh-hant-2023-01-20 branch January 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A user wrote a good first issue with clear instructions 📒 type:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants