Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lestrrat-go -> iproj #1908

Merged
merged 1 commit into from
Jun 17, 2022
Merged

lestrrat-go -> iproj #1908

merged 1 commit into from
Jun 17, 2022

Conversation

needkane
Copy link
Contributor

There're some bugs in lestrrat-go
Detail: iproj/file-rotatelogs#1

We'd love to see more contributions

Read how you can contribute to the project.

Please attach an issue link which your PR solves otherwise your work may be rejected.

There're some bugs in lestrrat-go
Detail:  iproj/file-rotatelogs#1
@needkane needkane requested a review from kataras as a code owner June 14, 2022 16:45
@CLAassistant
Copy link

CLAassistant commented Jun 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @needkane,

This library is used only in that example file, so good.
It's a fork of yours which improves some parts as I can see. LGTM, approved!

Before I can merge it, could you please sign the CLA (see actons below)?

@needkane
Copy link
Contributor Author

Hello @needkane,

This library is used only in that example file, so good. It's a fork of yours which improves some parts as I can see. LGTM, approved!

Before I can merge it, could you please sign the CLA (see actons below)?

done

@kataras
Copy link
Owner

kataras commented Jun 17, 2022

Thanks @needkane, it's merged.

@kataras kataras merged commit 1b22fb2 into kataras:master Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants