Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the invalid format of Context.RequestParams.Get() when the value is not string type #1860

Merged
merged 1 commit into from
Mar 17, 2022
Merged

fix the invalid format of Context.RequestParams.Get() when the value is not string type #1860

merged 1 commit into from
Mar 17, 2022

Conversation

lrita
Copy link
Contributor

@lrita lrita commented Mar 17, 2022

fix the invalid format of Context.RequestParams.Get() when the value is not string type, issue of https://github.com/kataras/iris/issues/1859

@lrita lrita requested a review from kataras as a code owner March 17, 2022 12:54
@CLAassistant
Copy link

CLAassistant commented Mar 17, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

kataras
kataras approved these changes Mar 17, 2022
View reviewed changes
Copy link
Owner

@kataras kataras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right @lrita, this should be %v, as %v will correctly render any custom struct/type which completes the fmt.Stringer (String() string) interface. I approved your PR, thanks a lot!

@kataras kataras merged commit af2d017 into kataras:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kataras kataras kataras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lrita @CLAassistant @kataras