Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: abount dependency injection #1475

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix bug: abount dependency injection #1475

merged 1 commit into from
Mar 23, 2020

Conversation

rocinantex
Copy link
Contributor

fix the issue: #1468

@rocinantex rocinantex requested a review from kataras as a code owner March 23, 2020 08:33
@kataras
Copy link
Owner

kataras commented Mar 23, 2020 •
edited
Loading

Thanks @rocinantex. You, correctly, did that on the master branch as I proposed you, which is under development and will be merged with v12 branch, that's why you shouldn't re-push the PR in v12 branch too, we will have issues on merging... but I will fix them as always...

@kataras kataras merged commit b6ac394 into kataras:v12 Mar 23, 2020
kataras added a commit that referenced this pull request Mar 24, 2020
@kataras
fix #1473 and add test for #1468 #1474 #1475
bb7dfdf
@rocinantex
Copy link
Contributor Author

Thanks @rocinantex. You, correctly, did that on the master branch as I proposed you, which is under development and will be merged with v12 branch, that's why you shouldn't re-push the PR in v12 branch too, we will have issues on merging... but I will fix them as always...

Okay, I see.

kataras added a commit that referenced this pull request Jul 26, 2020
@kataras
fix #1473 and add test for #1468 #1474 #1475
a694266 
Former-commit-id: 3e7d927761a5d5559b65ea3f91b94e3dc523a187
kataras added a commit that referenced this pull request Jul 26, 2020
@kataras
Merge pull request #1475 from rocinantex/v12
f19da31 
fix bug: abount dependency injection

Former-commit-id: d163c85d43e6e1db3f7858eefd6b6c654cb541c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kataras kataras Awaiting requested review from kataras kataras is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocinantex @kataras