[BUG] mvc can not get query param

[ghost]

Describe the bug
route can not handle query param when using mvc controller

To Reproduce
Steps to reproduce the behavior:
1.

mvc.Configure(app.Party("/user"), setup, func(app *mvc.Application) {
	app.Handle(new(controller.UserController))
})

type UserController struct {}

func (c *UserController) Get(req struct {
	Start int `url:"start"`
	Limit int `url:"limit"`
}) error {
	return  nil
}

GET: /usercontroller (./route\route.go:39)
     • iris-contrib/middleware/cors.(*Cors).Serve-fm (C:/Users/admin/go/pkg/mod/github.com/iris-contrib/middleware/[email protected]/cors.go:165)
     • controller.UserController.Get (./controller/user.go:67)

2. visit url like http://localhost/user?start=1&limit=2

Result: schema: invalid path "start" (and 1 other error)

[kataras]

I dont understand @ghost-void, the example runs here:

package main

import (
	"fmt"

	"github.com/kataras/iris/v12"
	"github.com/kataras/iris/v12/mvc"
)

func main() {
	app := newApp()

	app.Listen(":8080")
}

func newApp() *iris.Application {
	app := iris.New()
	mvc.Configure(app.Party("/user"), func(m *mvc.Application) {
		m.Handle(new(userController))
	})

	return app
}

type userController struct{}

func (c *userController) Get(req struct {
	Start int `url:"start"`
	Limit int `url:"limit"`
}) string {
	return fmt.Sprintf("Start: %d | Limit: %d\n", req.Start, req.Limit)
}

What version of Iris are u using? You should always try master branch before opening a new issue:

$ cd your_project
$ go get -u github.com/kataras/iris/v12@master
$ go run .

[ghost]

Sorry for that i missed some points.

I found that if controller has a public struct field, it happened.

type userController struct{
  Foo struct{}
}

@kataras

[kataras]

@ghost-void This is an expected behavior and it's the correct one. Let me explain,

This happens because Foo is not bind-ed to any dependency, so Iris will try to bind it from the request, just like the req struct {Start, Limit} in your controller's method. The problem is that because Foo is empty, the underline ctx.ReadBody, which controller will use to bind the Foo, returns an error because by-default Controller -> Unknown Dependency -> Can be readen by body -> ctx.ReadBody -> GET: -> ctx.ReadForm in your case it does not allow unknown url fields to be passed, and Foo does not contain any url or form struct fields tags, so it stops the execution, so the Get(req...) is not fired at all. At serve-time, if a struct field is request-scoped (like that Iris one, the automatic payload binding) then it starts with it, so calling method can have access to the controller's fields as expected. Try to log the error by registering an ErrorHandler and see by yourself:

mvc.Configure(app.Party("/user"), func(m *mvc.Application) {
	m.HandleError(func(ctx iris.Context, err error) {
                // this will print: schema: invalid path "start" (and 1 other error)
		println(err.Error()) 
	})

	m.Handle(new(userController))
})

Solutions by you:

1. Register a dependency for that Foo field with mvc.Application.Register or by Handle(&UserController{Foo: struct{}{}})
2. or remove it if it's useless

What I can do:

• You can register an error handler and allow the execution to continue but this is not allowed for struct fields (because if a field is empty (or nil!) and execution continues you may have a runtime panic if u try to access that field from the controller's method, and Iris is really careful protecting ur controller from things like that). So, I can just allow to have control over struct fields errors too so you can ignore the error and method executed with your expected results.
• As explained above, by-default form decoder does NOT allow undefined url query arguments and will throw an error, which can be ignored on an iris.Handler, but in controller if that error came from a struct, then it stops the execution as noted before. I can add a setting which form bindIng can just continue and do its work, even if a url parameter is not defined in your struct.

Stay tuned, I will push examples and implement both of the above ^

[kataras]

@ghost-void if you upgrade to the latest /v12@master branch the above code you post will work just fine, but please consider by notes above. Thanks a lot for opening this issue!

[ghost]

It works, nice job!

[kataras]

Thanks @ghost-void !