This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
metrics: Remove sleep for the footprint script #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that this issue has been solved kata-containers/agent#263, it is necessary to remove the workaround of sleeping. Fixes kata-containers#644 Signed-off-by: Gabriela Cervantes <[email protected]>
|
\o/ lgtm |
metrics/density/footprint_data.sh
Outdated
| # request ends up doing a kill anyhow | ||
| docker kill $c | ||
| sleep 3 | ||
| docker stop $c |
There was a problem hiding this comment.
Can we do a 'kill' or 'rm -f' instead please - issuing a 'stop' has a tendency to get the STOP ignored at the container end, and then that hits us with a default 10s timeout penalty, before docker issues a kill anyway.
See moby/moby#3766 and a number of other related Issues for details if interested.
So, this could probably just be a:
$ docker kill $(docker ps -qa)which is a little harsh, as it will kill all containers even if we did not launch them - but, I think the pre-init scripts have probably ensured that is the case already when running metrics tests.
thx!
GabyCT
force-pushed
the
topic/sleepfootprint
branch
from
33e86ee to
0694e29
Compare
|
@grahamwhaley changes applied :) |
|
lgtm |
grahamwhaley
approved these changes
Aug 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that this issue has been solved kata-containers/agent#263,
it is necessary to remove the workaround of sleeping.
Fixes #644
Signed-off-by: Gabriela Cervantes [email protected]