This repository was archived by the owner on Jun 28, 2024. It is now read-only.
metrics: use docker kill rather than docker stop #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For many of our 'used' test containers, issuing a `docker stop` actually results in the stop timing out (as it cannot signal the container to stop for any one of a number of potential reasons), and then docker reverts to a kill anyhow. The cost of this is a 10s delay per `stop`, whilst docker times out and then issues the kill. That costs us heavily when we are doing multi-container tests using say 20 or 100 containers, as each one takes a 10s overhead on stop/kill/removing it. Move all the metrics test `stops` to be `kills`. Fixes: kata-containers#561 Signed-off-by: Graham Whaley <[email protected]>
|
lgtm It would be great if we could drop the |
|
lgtm |
|
@jodh-intel - yeah - I need to verify that all the yamux type fixes have made it stable enough to drop those - and didn't have time right now. I thought I had an Issue open for that so we don't forget, but cannot see one. Let me go create.... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many of our 'used' test containers, issuing a
docker stopactually results in the stop timing out (as it cannot signal the
container to stop for any one of a number of potential reasons),
and then docker reverts to a kill anyhow. The cost of this is a
10s delay per
stop, whilst docker times out and then issues thekill. That costs us heavily when we are doing multi-container tests
using say 20 or 100 containers, as each one takes a 10s overhead
on stop/kill/removing it.
Move all the metrics test
stopsto bekills.Fixes: #561
Signed-off-by: Graham Whaley [email protected]