This repository was archived by the owner on Jun 28, 2024. It is now read-only.
metrics: density: serialise docker rm and stops #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parallel `docker rm -f` in the test often runs into the hang up detailed at: kata-containers/runtime#406 Until that is resolved, try to work around the hang with some timeouts and serialisation of the rm's. Fixes: kata-containers#475 Signed-off-by: Graham Whaley <[email protected]>
|
[WIP], as I want to see if this does resolve the hang up issues on the metrics CI VMs before we merge. |
|
OK, no longer WIP, as I've not seen a docker rm hangup on the memory test on this PR since - so, pls review, let's get merged and see if we can move the metrics CI on a step. |
grahamwhaley
changed the title
sboeuf
approved these changes
Jul 10, 2018
|
@chavafg - I think the initrd CI just triggered when I added/edited comments on this PR - can you check we have the 'not on comments' build flag ticked on that job pls? |
chavafg
approved these changes
Jul 10, 2018
|
@grahamwhaley weird, I've checked the job and cannot find that option. I've also checked the github webhook and everything seems fine. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parallel
docker rm -fin the test often runs intothe hang up detailed at:
kata-containers/runtime#406
Until that is resolved, try to work around the hang with
some timeouts and serialisation of the rm's.
Fixes: #475
Signed-off-by: Graham Whaley [email protected]