-
Notifications
You must be signed in to change notification settings - Fork 195
ci: Add CentOS dependencies for CRI-O shimv2 #2655
Conversation
.ci/setup_env_centos.sh
Outdated
# Extra CRI-O dependencies | ||
if [ "$centos_version" >= "8" ]; then | ||
curl -OkL http://mirror.centos.org/centos/7/os/x86_64/Packages/btrfs-progs-4.9.1-1.el7.x86_64.rpm | ||
sudo -E rpm -ivh btrfs-progs-4.9.1-1.el7.x86_64.rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oii, why don't use the btrfs for centos 8? https://centos.pkgs.org/8/elrepo-testing-x86_64/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devimc centos 8 at http://mirror.centos.org/centos/8/ does not have anymore the btrfs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devimc the elrepo-testing
is a third party repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabyCT what other filesystem could we use instead of btrfs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcvenegas btrfs
is a dependency to build CRI-O, I am not sure if there is another filesystem that we could use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GabyCT, we can simply skip btrfs without issues, just pass exclude_graphdriver_btrfs
to the BUILDTAGS.
/test-clh-metrics |
1 similar comment
/test-clh-metrics |
/test-centos |
/test |
8323289
to
400ab8d
Compare
/test-centos |
1 similar comment
/test-centos |
@GabyCT, lgtm. I'd just add one mention in the commit message that EL8 doesn't support btrfs. |
@fidencio thanks, I modify the buildtags |
400ab8d
to
ada088a
Compare
/test-centos |
244cb6f
to
0858ee0
Compare
/test-centos |
This PR adds the packages dependencies that are needed to build and install CRI-O for shimv2. We also exclude btrfs package dependency for CRI-O as EL8 doesn't support btrfs Fixes kata-containers#2654 Signed-off-by: Gabriela Cervantes <[email protected]>
/test |
This PR adds the packages dependencies that are needed to build and
install CRI-O for shimv2.
Fixes #2654
Signed-off-by: Gabriela Cervantes [email protected]