Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: Add CentOS dependencies for CRI-O shimv2 #2655

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Jun 17, 2020

This PR adds the packages dependencies that are needed to build and
install CRI-O for shimv2.

Fixes #2654

Signed-off-by: Gabriela Cervantes [email protected]

# Extra CRI-O dependencies
if [ "$centos_version" >= "8" ]; then
curl -OkL http://mirror.centos.org/centos/7/os/x86_64/Packages/btrfs-progs-4.9.1-1.el7.x86_64.rpm
sudo -E rpm -ivh btrfs-progs-4.9.1-1.el7.x86_64.rpm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oii, why don't use the btrfs for centos 8? https://centos.pkgs.org/8/elrepo-testing-x86_64/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devimc centos 8 at http://mirror.centos.org/centos/8/ does not have anymore the btrfs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devimc the elrepo-testing is a third party repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabyCT what other filesystem could we use instead of btrfs ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcvenegas btrfs is a dependency to build CRI-O, I am not sure if there is another filesystem that we could use

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabyCT, we can simply skip btrfs without issues, just pass exclude_graphdriver_btrfs to the BUILDTAGS.

@jcvenegas
Copy link
Member

/test-clh-metrics

1 similar comment
@jcvenegas
Copy link
Member

/test-clh-metrics

@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test-centos

@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test

@GabyCT GabyCT force-pushed the topic/enablecriocentos branch from 8323289 to 400ab8d Compare June 18, 2020 18:58
@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test-centos

1 similar comment
@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test-centos

@fidencio
Copy link
Member

@GabyCT, lgtm. I'd just add one mention in the commit message that EL8 doesn't support btrfs.

@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

@fidencio thanks, I modify the buildtags

@GabyCT GabyCT force-pushed the topic/enablecriocentos branch from 400ab8d to ada088a Compare June 18, 2020 19:34
@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test-centos

@GabyCT GabyCT force-pushed the topic/enablecriocentos branch 2 times, most recently from 244cb6f to 0858ee0 Compare June 18, 2020 20:21
@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test-centos

This PR adds the packages dependencies that are needed to build and
install CRI-O for shimv2. We also exclude btrfs package dependency
for CRI-O as EL8 doesn't support btrfs

Fixes kata-containers#2654

Signed-off-by: Gabriela Cervantes <[email protected]>
@GabyCT
Copy link
Contributor Author

GabyCT commented Jun 18, 2020

/test

@devimc devimc merged commit 1ed7380 into kata-containers:2.0-dev Jun 19, 2020
@GabyCT GabyCT deleted the topic/enablecriocentos branch September 8, 2021 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants