Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

ci: static check does not skip all files #2163

Closed
jcvenegas opened this issue Dec 11, 2019 · 0 comments · Fixed by #2164
Closed

ci: static check does not skip all files #2163

jcvenegas opened this issue Dec 11, 2019 · 0 comments · Fixed by #2164
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Description of problem

kata-containers/runtime#2344

Updates files of genearted files, but this are part of files to ignore by static checks, but the
scripts does not filter correctly

Expected result

Files are ignored for this PR

Actual result

Static checks are applied there.
@jcvenegas jcvenegas added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Dec 11, 2019
jcvenegas added a commit to jcvenegas/kata-test that referenced this issue Dec 11, 2019
@jcvenegas
fix: skip paths for static checks
d197237 
Function to skip paths takes a list of values separated
by spaces (space or new line), if it is just space separated values
grep will not filter values correctly, this commit
converts the list in to a bash array and then iterate the list to
ensure every item checked.

Fixes: kata-containers#2163

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@jcvenegas jcvenegas mentioned this issue Dec 11, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: skip paths for static checks jcvenegas/kata-test
1 participant
@jcvenegas