This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: qemu: Call removeDeviceFromBridge for virtio-blk #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of virtio-block, we hotplug devices to a bridge. We need to remove device from bridge while stopping a container. Fixes kata-containers#82 Signed-off-by: Archana Shinde <[email protected]>
sboeuf
approved these changes
Mar 20, 2018
|
LGTM |
|
lgtm. You know what I'm going to say though: "tests" :) Can we either have a unit-test or an issue for another type of test to ensure this works as expected? |
|
@jodh-intel See #84 |
|
I have created an issue for adding the tests for virtio-block. If we are happy with this, can someone merge this. |
|
lgtm |
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
protocols: grpc: Rely on exec_id provided by the runtime
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of virtio-block, we hotplug devices to a bridge.
We need to remove device from bridge while stopping a
container.
Fixes #82
Signed-off-by: Archana Shinde [email protected]