This repository has been archived by the owner on May 12, 2021. It is now read-only.
FIPS: Add support for starting VM in FIPS mode. #2171
Merged
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on kata-containers/packaging#788 |
amshinde
force-pushed
the
support-fips-mode
branch
from
8d2ab0e to
bd84d0c
Compare
jodh-intel
approved these changes
Nov 8, 2019
pkg/katautils/create.go
Outdated
|
|
||
| enabled, err := strconv.Atoi(strings.Trim(string(content), "\n\t ")) | ||
| if err != nil { | ||
| // Enexpected format, ignore and simply return early |
There was a problem hiding this comment.
Nit: typo - "unexpected".
|
commit message: typo: s/algororithms/algorithms |
devimc
approved these changes
Nov 8, 2019
FIPS are a set of security standards for encryption algorithms in user and kernel space among others. Have Kata support this by starting the VM for a container in FIPS mode on detecting that the host is running in FIPS mode. Depends-on: github.com/kata-containers/packaging#788 Fixes kata-containers#2170 Signed-off-by: Archana Shinde <[email protected]>
amshinde
force-pushed
the
support-fips-mode
branch
from
bd84d0c to
0bd41b9
Compare
|
Typos fixed. |
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
==========================================
+ Coverage 50.94% 50.96% +0.02%
==========================================
Files 110 110
Lines 15205 15221 +16
==========================================
+ Hits 7746 7758 +12
- Misses 6505 6507 +2
- Partials 954 956 +2 |
bergwolf
approved these changes
Nov 11, 2019
|
failed ci looks unrelated (kata-containers/tests#2069) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIPS are a set of security standards for encryption algororithms
in user and kernel space among others.
Have Kata support this by starting the VM for a container
in FIPS mode on detecting that the host is running in FIPS mode.
Depends-on: github.com/kata-containers/packaging#788
Fixes #2170
Signed-off-by: Archana Shinde [email protected]