kata-env: kata-env error out when there is no VERSION_ID. #1178

yyyeerbo · 2019-01-25T10:45:20Z

For example, under debian buster/sid. Those information should be
provide with best effort instead of error out.

Signed-off-by: Yang Bo [email protected]

yyyeerbo · 2019-01-25T10:46:03Z

/test

grahamwhaley · 2019-01-25T10:49:47Z

cli/utils.go

@@ -71,7 +71,7 @@ func getDistroDetails() (name, version string, err error) {
 			}
 		}

-		if name != "" && version != "" {
+		if name != "" || version != "" {


I agree, if we found one of them we should probably return it.
I suspect it might be good if we set the unfound item to something like <not set> - and maybe do that for both if neither is found, and not error out at all. @jodh-intel - wdyt?

we return what we know and what we don't know(set to <not set> or <unknown> looks better, I think. :)

amshinde · 2019-01-25T22:18:11Z

/test

amshinde · 2019-01-25T22:20:12Z

lgtm, with returning the not found item as unknown or not-set

yyyeerbo · 2019-01-28T01:30:34Z

Update to return "<<unknown>>" when name/version is not defined.

grahamwhaley

thanks for the updates!
lgtm

grahamwhaley · 2019-01-28T10:09:17Z

/test

jodh-intel · 2019-01-28T11:11:10Z

Thanks @yyyeerbo. I'm hoping we can overcome this issue (kata-containers/documentation#358 (review)), but I agree this PR is a good idea regardless.

lgtm

amshinde · 2019-01-28T18:21:36Z

/retest

jodh-intel · 2019-01-29T10:24:32Z

/retest

gnawux · 2019-01-31T03:14:23Z

/retest

yyyeerbo · 2019-01-31T05:06:47Z

fix bug and testcase..

gnawux · 2019-01-31T05:07:55Z

/test

For example, under debian buster/sid. Those information should be provide with best effort instead of error out. Set name and version to "<<unknown>>" if they are not defined. Fixes: kata-containers#1177 Signed-off-by: Yang Bo <[email protected]>

yyyeerbo · 2019-01-31T06:07:12Z

fix testcases

caoruidong · 2019-01-31T06:11:49Z

/test

jodh-intel · 2019-01-31T09:18:49Z

Restarted failing CIs (metrics timed out).

gnawux

now let's wait the test results

bergwolf

LGTM

devimc · 2019-01-31T14:36:13Z

lgtm

ARM and metrics CIs are not stable, merging...

grahamwhaley reviewed Jan 25, 2019

View reviewed changes

yyyeerbo force-pushed the wip branch from e5b98c0 to 3efbd8c Compare January 28, 2019 01:29

grahamwhaley previously approved these changes Jan 28, 2019

View reviewed changes

yyyeerbo dismissed grahamwhaley’s stale review via da4d4c9 January 31, 2019 04:54

yyyeerbo force-pushed the wip branch from 3efbd8c to da4d4c9 Compare January 31, 2019 04:54

yyyeerbo force-pushed the wip branch from da4d4c9 to 4f51687 Compare January 31, 2019 06:06

gnawux approved these changes Jan 31, 2019

View reviewed changes

bergwolf approved these changes Jan 31, 2019

View reviewed changes

devimc merged commit 5f1ca16 into kata-containers:master Jan 31, 2019

egernst mentioned this pull request Feb 26, 2019

Stable 1.5.1 rc #1281

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

kata-env: kata-env error out when there is no VERSION_ID. #1178

kata-env: kata-env error out when there is no VERSION_ID. #1178

yyyeerbo commented Jan 25, 2019

yyyeerbo commented Jan 25, 2019

grahamwhaley Jan 25, 2019

yyyeerbo Jan 25, 2019 •

edited

Loading

amshinde commented Jan 25, 2019

amshinde commented Jan 25, 2019 •

edited

Loading

yyyeerbo commented Jan 28, 2019 •

edited

Loading

grahamwhaley left a comment

grahamwhaley commented Jan 28, 2019

jodh-intel commented Jan 28, 2019 •

edited by amshinde

Loading

amshinde commented Jan 28, 2019

jodh-intel commented Jan 29, 2019

gnawux commented Jan 31, 2019

yyyeerbo commented Jan 31, 2019

gnawux commented Jan 31, 2019

yyyeerbo commented Jan 31, 2019

caoruidong commented Jan 31, 2019

jodh-intel commented Jan 31, 2019

gnawux left a comment

bergwolf left a comment

devimc commented Jan 31, 2019 •

edited by amshinde

Loading

kata-env: kata-env error out when there is no VERSION_ID. #1178

kata-env: kata-env error out when there is no VERSION_ID. #1178

Conversation

yyyeerbo commented Jan 25, 2019

yyyeerbo commented Jan 25, 2019

grahamwhaley Jan 25, 2019

Choose a reason for hiding this comment

yyyeerbo Jan 25, 2019 • edited Loading

Choose a reason for hiding this comment

amshinde commented Jan 25, 2019

amshinde commented Jan 25, 2019 • edited Loading

yyyeerbo commented Jan 28, 2019 • edited Loading

grahamwhaley left a comment

Choose a reason for hiding this comment

grahamwhaley commented Jan 28, 2019

jodh-intel commented Jan 28, 2019 • edited by amshinde Loading

amshinde commented Jan 28, 2019

jodh-intel commented Jan 29, 2019

gnawux commented Jan 31, 2019

yyyeerbo commented Jan 31, 2019

gnawux commented Jan 31, 2019

yyyeerbo commented Jan 31, 2019

caoruidong commented Jan 31, 2019

jodh-intel commented Jan 31, 2019

gnawux left a comment

Choose a reason for hiding this comment

bergwolf left a comment

Choose a reason for hiding this comment

devimc commented Jan 31, 2019 • edited by amshinde Loading

yyyeerbo Jan 25, 2019 •

edited

Loading

amshinde commented Jan 25, 2019 •

edited

Loading

yyyeerbo commented Jan 28, 2019 •

edited

Loading

jodh-intel commented Jan 28, 2019 •

edited by amshinde

Loading

devimc commented Jan 31, 2019 •

edited by amshinde

Loading