This repository has been archived by the owner on May 12, 2021. It is now read-only.
network: Don't assume multiple queues support by default #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 14, 2018 14:50
In order to prevent from future duplication of calls into the hypervisor interface, the hypervisor is directly passed as part of the xConnectVMNetwork() function. Because this does not apply the disconnection case, this commit splits the former function into two separate ones. Signed-off-by: Sebastien Boeuf <[email protected]>
The point of knowing the number of CPUs from the network perspective is to determine the number of queues that can be allocated to the network interface of the our virtual machine. Therefore, it's more logical to name it queues from a network.go perspective. Signed-off-by: Sebastien Boeuf <[email protected]>
Each hypervisor is different and supports different options regarding the network interface it creates. In particular, the multiqueue option is not supported by Firecracker and should not be assumed by default. Signed-off-by: Sebastien Boeuf <[email protected]>
…eues In order to properly setup the network, hence allocate or not multiple queues, this commit makes sure that the hypervisor capabilities are checked for this. Fixes kata-containers#1027 Signed-off-by: Sebastien Boeuf <[email protected]>
|
LGTM |
egernst
reviewed
Dec 14, 2018
egernst
approved these changes
Dec 15, 2018
|
/test |
|
Let me fix the CI right now! |
|
/test |
|
LGTM. |
|
@egernst - rather than hard code the queue cap limit (to 4 or whatever), add a toml config option to allow that to be set, and default that cap to 4 maybe. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes slightly the network code to be able to check the hypervisor capabilities. A new hypervisor capabilities called
multiQueueSupporthas been added, and can be used to determine if the network should be setup with or without multiple queues.Fixes #1027