Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Update cc-runtime to fix CI #44

Closed
jodh-intel opened this issue Mar 2, 2018 · 0 comments · Fixed by #47
Closed

Update cc-runtime to fix CI #44

jodh-intel opened this issue Mar 2, 2018 · 0 comments · Fixed by #47
Assignees

Comments

@jodh-intel
Copy link
Contributor

Once clearcontainers/runtime#1044 lands, we need to update the runtime here to fix the CI.

Note that we also need kata-containers/tests#107 to be fixed.

chavafg added a commit to chavafg/runtime-1 that referenced this issue Mar 8, 2018
Update `cc-runtime` to release 3.0.21 which have the necessary
fixes for the new agent.

Shortlog:

	5e27776 vendor: Update virtcontainers vendoring
	dc15173 cc-env: Include hypervisor block storage driver in cc-env output
	1768dd5 config: Add configuration option for hypervisor block storage driver
	accaa9d vendor: Vendor virtcontainers for SCSI support

Fixes: kata-containers#44.

Signed-off-by: Salvador Fuentes <[email protected]>
@chavafg chavafg self-assigned this Mar 8, 2018
chavafg added a commit to chavafg/runtime-1 that referenced this issue Mar 8, 2018
Update `cc-runtime` to release 3.0.21 which has the necessary
fixes for the new agent.

Shortlog:

	5e27776 vendor: Update virtcontainers vendoring
	dc15173 cc-env: Include hypervisor block storage driver in cc-env output
	1768dd5 config: Add configuration option for hypervisor block storage driver
	accaa9d vendor: Vendor virtcontainers for SCSI support

Fixes: kata-containers#44.

Signed-off-by: Salvador Fuentes <[email protected]>
bergwolf referenced this issue in bergwolf/kata-runtime Jul 5, 2018
I got following warning after upgrading dep tool:

Warning: the following project(s) have [[constraint]] stanzas in Gopkg.toml:

  ✗  github.com/hashicorp/yamux

However, these projects are not direct dependencies of the current project:
they are not imported in any .go files, nor are they in the 'required' list in
Gopkg.toml. Dep only applies [[constraint]] rules to direct dependencies, so
these rules will have no effect.

Either import/require packages from these projects so that they become direct
dependencies, or convert each [[constraint]] to an [[override]] to enforce rules
on these projects, if they happen to be transitive dependencies,

So let's convert constraint to override over yamux. In the meanwhile,
update the yamux vendor. Full commit list:

4c2fe0d (origin/b-consul-3040) Dont output keepalive error when the session is closed
f21aae5 Make sure to drain the timer channel on defer, and a clarifying comment
601ccd8 Make receive window update logic a bit cleaner
02d320c Uses timer pool in sendNoWait, like in waitForSendErr
cf433c5 window update unit test for partial read; benchmark large buffer
ca8dfd0 improve memory utilization in receive buffer, fix flow control
683f491 Fix race around read and write deadlines in Stream (#52)
40b86b2 Add public session CloseChan method (#44)

Note that commit 4c2fe0d might also help kata-containers/agent/issues/231.

Signed-off-by: Peng Tao <[email protected]>
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
zklei pushed a commit to zklei/runtime that referenced this issue Jun 13, 2019
Full commit list:
91c5847 Add go.mod
4c2fe0d Dont output keepalive error when the session is closed
f21aae5 Make sure to drain the timer channel on defer, and a clarifying comment
601ccd8 Make receive window update logic a bit cleaner
02d320c Uses timer pool in sendNoWait, like in waitForSendErr
cf433c5 window update unit test for partial read; benchmark large buffer
ca8dfd0 improve memory utilization in receive buffer, fix flow control
683f491 Fix race around read and write deadlines in Stream (kata-containers#52)
40b86b2 Add public session CloseChan method (kata-containers#44)

Signed-off-by: Peng Tao <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants