This repository has been archived by the owner on May 12, 2021. It is now read-only.
Factory: Fix fake return value issue on creating template #1333
Comments
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 7, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error to template.New in NewFactory. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 7, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error to template.New in NewFactory. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 7, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error to template.New in NewFactory. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 13, 2019
This commit fix two issue. Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 14, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Change-Id: Ie711c849faf070ba060d5e9b50948dc9ae75020e Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 14, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 14, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 15, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 15, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jongwu
added a commit
to jongwu/runtime
that referenced
this issue
Mar 15, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
egernst
pushed a commit
to egernst/runtime
that referenced
this issue
Apr 3, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
jcvenegas
pushed a commit
to jcvenegas/runtime
that referenced
this issue
Apr 3, 2019
Now, function NewFactory will return nil even create template does't complete. As for this, it will tell user that factory has been initialized no matter whether the template is created or not. This patch correct it by adding another return value of error in NewFactory. Testing initFactoryCommand when enable template will need root privilege to mount tmpfs. So skip it for no-root user. Testing initFactoryCommand func will create template, but no proxy type assigned to VMconfig which will using katabuiltinProxy instead. this will lead to failure for this type of proxy will check proxyparams which contains many null value. This commit fix it by substitute katabuiltinProxy as noopProxy when for test purpose. Fixes: kata-containers#1333 Signed-off-by: Jianyong Wu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description of problem
Now, function NewFactory will return nil even create template
does't complete. As for this, it will tell user that factory
has been initialized no matter whether the template is created
or not.
Expected result
Actual result
The text was updated successfully, but these errors were encountered: