This repository has been archived by the owner on May 12, 2021. It is now read-only.

unit-test: bugs on a few unit tests on aarch64 #1200

Closed

Pennyzct opened this issue Jan 31, 2019 · 0 comments

Contributor

Pennyzct commented Jan 31, 2019

Description of problem

09:55:00 cli/kata-check_arm64.go:129:9:warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
09:55:02 virtcontainers/qemu_arm64_test.go:43:23:warning: unused variable or constant undeclared name: virt (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:50:11:warning: unused variable or constant undeclared name: defaultMemSlots (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:54:40:warning: unused variable or constant too few arguments in call to arm64.memoryTopology (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:29:23:warning: unused variable or constant undeclared name: virt (varcheck)
09:55:02 cli/kata-check_test.go:141:113:warning: unused variable or constant undeclared name: TestDataa (varcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:43:23:warning: unused struct field undeclared name: virt (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:50:11:warning: unused struct field undeclared name: defaultMemSlots (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:54:40:warning: unused struct field too few arguments in call to arm64.memoryTopology (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:29:23:warning: unused struct field undeclared name: virt (structcheck)
09:55:03 cli/kata-check_test.go:141:113:warning: unused struct field undeclared name: TestDataa (structcheck)
09:55:03 cli/kata-check_test.go:141:113:warning: undeclared name: TestDataa (unused)
09:55:04 cli/kata-check_test.go:141:113:warning: undeclared name: TestDataa (staticcheck)
09:55:05 Build step 'Execute shell' marked build as failure

There existed some bugs on a few unit tests on aarch64, and I will fix them asap.
During the time, In case ARM CI blocks other PRs, please bring it down temporarily.
@grahamwhaley @jodh-intel

The text was updated successfully, but these errors were encountered:

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

d079ed3

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

afcebcb

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

2d4773f

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

d88d45c

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

6bc3f62

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

c6e6166

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

b8b5253

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

31a8f0f

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

487ea1c

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

7b4f21c

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

9e39357

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

389495a

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

1c0333b

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

03d5faa

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

82b66ee

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          runtime: add appendBridges for arm64

c2bdeb1

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

e670203

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          runtime: add appendBridges for arm64

3b6eae2

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

70a719a

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

0679f6f

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

b44e9b1

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          runtime: add appendBridges for arm64

f713415

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

217430c

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

e93fb0b

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          runtime: add appendBridges for arm64

3ec56ea

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

1b967a4

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

Pennyzct added a commit to Pennyzct/runtime that referenced this issue


          unit-test: refine func TestGetCPUDetails

23c554e

refine struct testData in func TestGetCPUDetails to remove redundant
/unused struct field expectedVendor and expectedModel

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

grahamwhaley closed this as completed in

44e2b9a

egernst pushed a commit to egernst/runtime that referenced this issue


          unit-test: struct TestDataa should be included in arch-indenpedent .g…

e2a6373

…o file

argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly
defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go,
cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in
cli/kata-check_test.go. change its name to testCPUDetail for better understanding.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

egernst pushed a commit to egernst/runtime that referenced this issue


          unit-test: refine qemu_arm64_test.go

b074797

refine a set of test functions under qemu_arm64_test.go. e.g. test
func for memoryTopology shouldn't be the same one on amd64, since
for now, we don't support nvdimm on arm64.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

egernst pushed a commit to egernst/runtime that referenced this issue


          unit-test: test func for RunningOnVMM should be arch-dependent

ce29252

original tests for func RunningOnVMM are sort of amd64-specific,
since all other archs don't support nested VMM for now.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

egernst pushed a commit to egernst/runtime that referenced this issue


          runtime: add appendBridges for arm64

e1c5445

since generic func genericAppendBridges and genericBridges
is also applied for machine type QemuVirt, we use it as implementation
for appendBridges and bridges on aarch64.
since const defaultPCBridgeBus is used in generic func
genericAppendBridges for pc machine, we should define it once
in generic file, instead of redefining it in different
arch-specific files.

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

egernst pushed a commit to egernst/runtime that referenced this issue


          unit-test: add nolint comment to avoid unused warning

e770e6a

since all generic* could bring unused linter warnings, which lead to
CI crash, we add nolint comment to avoid them.

Fixes: kata-containers#1200

Signed-off-by: Samuel Ortiz <[email protected]>
Signed-off-by: Penny Zheng <[email protected]>

egernst pushed a commit to egernst/runtime that referenced this issue


          unit-test: refine func TestGetCPUDetails

b7588dc

refine struct testData in func TestGetCPUDetails to remove redundant
/unused struct field expectedVendor and expectedModel

Fixes: kata-containers#1200

Signed-off-by: Penny Zheng <[email protected]>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.