firecracker: Close the vsock vhostfd

Unlike QEMU firecracker cannot accept a fd as part of the REST API. Close the vsock vhostfd close to the point where we launch the VM. Note: This is still racy. Signed-off-by: Manohar Castelino <[email protected]>
kata-containers · Dec 20, 2018 · 5c9e7a1 · 5c9e7a1
1 parent 40e7fe9
commit 5c9e7a1
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/virtcontainers/fc.go b/virtcontainers/fc.go
@@ -437,6 +437,10 @@ func (fc *firecracker) fcAddVsock(vs kataVSOCK) error {
 	if err != nil {
 		return err
 	}
+	//Still racy. There is no way to send an fd to the firecracker
+	//REST API. We could release this just before we start the instance
+	//but even that will not eliminate the race
+	vs.vhostFd.Close()
 	return nil
 }