Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

main: coredump on internal error #60

Closed

Conversation

jodh-intel
Copy link
Contributor

Override the default golang panic handling by printing a full traceback
(not just for the current goroutine) and dumping core to allow
crash-handling programs to log the details.

Fixes #59.

Signed-off-by: James O. D. Hunt [email protected]

Override the default golang panic handling by printing a full traceback
(not just for the current goroutine) and dumping core to allow
crash-handling programs to log the details.

Fixes kata-containers#59.

Signed-off-by: James O. D. Hunt <[email protected]>
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I think the actual generation of core files is still ultimately controlled by the user ulimit settings (and thus we won't just dump core files around the place ad infinitum)...
lgtm

@jodh-intel
Copy link
Contributor Author

Yes - this PR simply allows the component to crash, it doesn't actually do it until limits.conf is set appropriately, but that's an admin concern.

@bergwolf
Copy link
Member

bergwolf commented Mar 5, 2018

lgtm

Approved with PullApprove

@jodh-intel
Copy link
Contributor Author

CI failing due to clearcontainers/runtime#1044.

@sboeuf
Copy link

sboeuf commented Mar 5, 2018

LGTM

Approved with PullApprove

@jodh-intel
Copy link
Contributor Author

Closing to rework in same manner as kata-containers/shim#59.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants