This repository has been archived by the owner on May 12, 2021. It is now read-only.
docs: cpu: resources: fix vcpu calculation formula #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formula is not updated according on how is done in kata-runtime. Fixes: kata-containers#489 Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas
changed the title
|
I would actually clarify in the commit message that this is a fix; it isn't so much that it doesn't match . the code, its that it was wrong? I'm not sure we really changed the math in the code... |
devimc
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The formula is not updated according on
how is done in kata-runtime.
Fixes: #489
Signed-off-by: Jose Carlos Venegas Munoz [email protected]